Fix logic that determines whether to spoof GetModuleFileNameW(nullptr) #828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was depending on figuring out where it was called from, but the logic was unreliable and there is no apparent way to fix it. Now, it switches spoofing on just before loading SkyrimSE.exe (so the loaded DLLs see the path they expect). Requires a companion fix in TIltedCore:TiltedPhoques::GetPath() to persist the value found originally, so it doesn't change out from under with late callers. If you code has only late callers, just add a call before loading your game binary.
rfortier
force-pushed
the
fix/TiltedCore-TiltedPhoques-GetPath
branch
from
3e63256 to
6f4ab19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was depending on figuring out where it was called from, but the logic was unreliable and there is no apparent way to fix it.
Prerequisite is TiltedCore/PR #12 being merged and xmake-repo updated to include version v0.2.8 of TiltedCore, so this will stay draft until that happens.
Fixes: now, it switches spoofing on just before loading SkyrimSE.exe (so the loaded DLLs see the path they expect).
The required companion fix in TIltedCore:TiltedPhoques::GetPath() persists the value found originally, so it doesn't change out from under with late callers. If your code has only late callers, just add a call before loading your game binary.